Skip to content

feat(FilterPicker): isLoadingItems flag#1124

Merged
tenphi merged 6 commits intomainfrom
feat-filterpicker-loading-items
Apr 16, 2026
Merged

feat(FilterPicker): isLoadingItems flag#1124
tenphi merged 6 commits intomainfrom
feat-filterpicker-loading-items

Conversation

@tenphi
Copy link
Copy Markdown
Member

@tenphi tenphi commented Apr 15, 2026

Note

Medium Risk
Introduces new loading-state behavior and focus/ARIA handling in FilterListBox/FilterPicker, which could affect keyboard navigation and accessibility if edge cases regress.

Overview
Adds a new isLoadingItems state to FilterPicker and FilterListBox for non-blocking async option loading: the trigger stays enabled, a spinner is shown in the trigger, and a loading disclaimer renders inside the popover.

When isLoadingItems is set, FilterListBox can hide the search input (unless allowsCustomValue) and transfers keyboard focus/combobox semantics to the disclaimer to preserve arrow-key navigation; the disclaimer text is customizable via loadingItemsLabel. Docs/specs, styling modifiers (loading-items), layout updates, and new Storybook examples are included, along with a changeset for a minor @cube-dev/ui-kit bump.

Reviewed by Cursor Bugbot for commit 31251f3. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cube-ui-kit Ready Ready Preview, Comment Apr 15, 2026 2:47pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 31251f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

📦 NPM canary release

Deployed canary version 0.0.0-canary-98a60ee.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

🏋️ Size limit report

Name Size Passed?
All 367.68 KB (+0.08% 🔺) Yes 🎉
Tree shaking (just a Button) 110.46 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

🧪 Storybook is successfully deployed!

Comment thread src/components/fields/FilterPicker/FilterPicker.tsx
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f9c1e5c. Configure here.

Comment thread src/components/fields/FilterListBox/FilterListBox.tsx
@tenphi tenphi merged commit 9d3785c into main Apr 16, 2026
16 checks passed
@tenphi tenphi deleted the feat-filterpicker-loading-items branch April 16, 2026 09:16
@github-actions github-actions bot mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant